[feat](doris-catalog) doris cross-cluster insert#60557
Open
TsukiokaKogane wants to merge 7 commits intoapache:masterfrom
Open
[feat](doris-catalog) doris cross-cluster insert#60557TsukiokaKogane wants to merge 7 commits intoapache:masterfrom
TsukiokaKogane wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 31471 ms |
ClickBench: Total hot run time: 28.23 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 31323 ms |
ClickBench: Total hot run time: 28.66 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
morningman
changed the title
Contributor
|
run buildall |
morningman
reviewed
Feb 9, 2026
| // Remote transaction request and Result definitions for cross-cluster export. | ||
| // These structs are used by beginRemoteTxn/commitRemoteTxn/abortRemoteTxn RPCs. | ||
| struct TBeginRemoteTxnRequest { | ||
| 1: required string user |
Contributor
There was a problem hiding this comment.
always use optional for all fields
| 1: required string user | ||
| 2: required string passwd | ||
| 3: optional string token | ||
| 4: required string db |
Contributor
There was a problem hiding this comment.
better add catalog, even if currently only support "internal" catalog
| } catch (Exception e) { | ||
| long costMs = System.currentTimeMillis() - startTime; | ||
| LOG.warn("get master address for catalog {} failed, cost={}ms", name, costMs, e); | ||
| throw new RuntimeException(e.getMessage()); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException(e.getMessage()); | |
| throw new RuntimeException(Util.getRootCause(e), e); |
Same suggestion for other places
| contains("VOlapScanNode") | ||
| } | ||
| sql """ | ||
| insert OVERWRITE table `${catalog_name}`.`${db_name}`.`test_remote_doris_all_types_insert` select /*+ SET_VAR(enable_nereids_distribute_planner=true, enable_sql_cache=true) */ * from `${catalog_name}`.`${db_name}`.`test_remote_doris_all_types_select_t` |
Contributor
There was a problem hiding this comment.
What is the behavior of setting these variables?
Does it affect remote cluster?
Contributor
There was a problem hiding this comment.
And why we set these 2 variables?
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #60295
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)