[fix](nereids) Fix incorrect isDomain parsing in SET PASSWORD statement#60565
Open
bobhan1 wants to merge 3 commits intoapache:masterfrom
Open
[fix](nereids) Fix incorrect isDomain parsing in SET PASSWORD statement#60565bobhan1 wants to merge 3 commits intoapache:masterfrom
bobhan1 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30560 ms |
ClickBench: Total hot run time: 28.96 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Fix incorrect
isDomainflag parsing inSET PASSWORDstatement.When parsing
SET PASSWORD FOR 'user'@'host'statement, theisDomainflag was incorrectly set totruebecause the previous code usedctx.userIdentify().ATSIGN() != nullto determine if a user is a domain user. Since the@symbol always exists in'user'@'host'format,isDomainwas alwaystrue, which is wrong.The correct behavior:
'user'@'host'(single quotes) →isDomain = false(regular user)'user'@("domain")(parentheses around host) →isDomain = true(domain user)This PR fixes the issue by reusing the existing
visitUserIdentify()method which correctly handles theisDomainflag.Release note
Fix SET PASSWORD statement incorrectly marking regular users as domain users.
Check List (For Author)
Test
Behavior changed:
SET PASSWORD FOR 'user'@'%'would fail because the user was incorrectly treated as a domain user. Now it works correctly.Does this need documentation?
Check List (For Reviewer who merge this PR)