Skip to content

[fix](test) replace hardcoded IP with variable in group commit redirect test#60573

Open
liaoxin01 wants to merge 1 commit intoapache:masterfrom
liaoxin01:fix/group_commit_redirect_test_hardcoded_ip
Open

[fix](test) replace hardcoded IP with variable in group commit redirect test#60573
liaoxin01 wants to merge 1 commit intoapache:masterfrom
liaoxin01:fix/group_commit_redirect_test_hardcoded_ip

Conversation

@liaoxin01
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings February 6, 2026 08:51
@Thearas
Copy link
Contributor

Thearas commented Feb 6, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes hardcoded IP addresses in the group commit redirect test by replacing them with the dynamic feIp variable. The test validates redirect behavior when enable_group_commit_streamload_be_forward is enabled, checking that the default (empty) redirect policy correctly routes to the FE's actual IP address rather than a hardcoded test IP.

Changes:

  • Replaced hardcoded IP 11.20.20.19 with $feIp variable in default redirect policy assertions
  • Ensures test works correctly in dynamic/containerized environments where IPs are not fixed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants