Skip to content

[check](column)const is only allowed at the top level.#60578

Open
Mryange wants to merge 2 commits intoapache:masterfrom
Mryange:check-const-in-column
Open

[check](column)const is only allowed at the top level.#60578
Mryange wants to merge 2 commits intoapache:masterfrom
Mryange:check-const-in-column

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Feb 6, 2026

What problem does this PR solve?

check nested const occurrences; const is only allowed at the top level.
e.g. const(nullable(...)) is allowed.
const(array(const(...))) is not allowed.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Feb 6, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30306 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d7781d47a4c953e47371186bd2f812e2355f419, data reload: false

------ Round 1 ----------------------------------
q1	17682	4477	4281	4281
q2	2079	348	236	236
q3	10144	1327	740	740
q4	10211	787	308	308
q5	8152	2252	1902	1902
q6	217	178	144	144
q7	862	734	607	607
q8	9267	1434	1201	1201
q9	4940	4650	4607	4607
q10	6948	1950	1571	1571
q11	545	295	294	294
q12	400	373	215	215
q13	17788	4324	3272	3272
q14	239	226	213	213
q15	920	824	805	805
q16	678	671	626	626
q17	708	789	573	573
q18	6826	5935	5659	5659
q19	1480	984	610	610
q20	508	485	374	374
q21	2533	1830	1787	1787
q22	361	327	281	281
Total cold run time: 103488 ms
Total hot run time: 30306 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4427	4372	4337	4337
q2	258	349	254	254
q3	2090	2675	2245	2245
q4	1364	1747	1301	1301
q5	4333	4275	4383	4275
q6	207	172	136	136
q7	1816	1812	1641	1641
q8	2810	2554	2465	2465
q9	7538	7486	7525	7486
q10	2849	2970	2657	2657
q11	544	481	465	465
q12	695	783	634	634
q13	3771	4451	3631	3631
q14	344	300	297	297
q15	893	808	826	808
q16	691	740	680	680
q17	1156	1404	1396	1396
q18	8189	7833	8269	7833
q19	888	845	848	845
q20	2075	2227	2040	2040
q21	4711	4575	4231	4231
q22	596	537	515	515
Total cold run time: 52245 ms
Total hot run time: 50172 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d7781d47a4c953e47371186bd2f812e2355f419, data reload: false

query1	0.06	0.04	0.04
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.11	0.11
query5	0.28	0.26	0.25
query6	1.17	0.69	0.67
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.56	0.49	0.49
query10	0.55	0.54	0.53
query11	0.14	0.09	0.09
query12	0.14	0.10	0.10
query13	0.65	0.61	0.61
query14	1.08	1.07	1.06
query15	0.87	0.87	0.86
query16	0.40	0.40	0.41
query17	1.15	1.09	1.13
query18	0.22	0.20	0.20
query19	2.05	1.99	1.96
query20	0.02	0.01	0.01
query21	15.40	0.30	0.15
query22	5.16	0.07	0.05
query23	15.86	0.28	0.10
query24	2.01	0.70	0.51
query25	0.12	0.09	0.08
query26	0.17	0.14	0.14
query27	0.07	0.06	0.06
query28	4.08	1.15	0.96
query29	12.63	3.94	3.16
query30	0.28	0.13	0.11
query31	2.81	0.65	0.40
query32	3.23	0.59	0.50
query33	3.20	3.21	3.22
query34	16.44	5.48	4.72
query35	4.77	4.79	4.71
query36	0.64	0.49	0.50
query37	0.10	0.07	0.08
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.19	0.16	0.14
query41	0.08	0.03	0.04
query42	0.04	0.03	0.04
query43	0.04	0.04	0.03
Total cold run time: 98.85 s
Total hot run time: 28.39 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants