Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 30658 ms |
ClickBench: Total hot run time: 28.39 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Pull request overview
Removes dead code and tightens immutability in the BE codebase by eliminating unused RowCursor key-building helpers and making a runtime-filter flag immutable.
Changes:
- Make
RuntimeFilter::_has_remote_targetaconst bool(initialized via the existing constructor initializer list). - Remove unused
RowCursor::build_max_key()/RowCursor::build_min_key()declarations and definitions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| be/src/runtime_filter/runtime_filter.h | Makes the remote-target flag immutable (const) while preserving constructor initialization. |
| be/src/olap/row_cursor.h | Removes unused build_max_key / build_min_key APIs from the public interface. |
| be/src/olap/row_cursor.cpp | Removes unused implementations of build_max_key / build_min_key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)