Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Dec 26, 2024

Subjob is failing in today's builds - make tool issues when running protobuf bits.

GitHub CI recently moved to unbuntu 24 for 'latest' install.

eg
https://github.com/apache/drill/actions/runs/12504907055/job/34889343661

@pjfanning
Copy link
Member Author

@cgivre the Splunk tests are failing and I don't think the PR changes here are the cause.

OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Error:  Tests run: 16, Failures: 2, Errors: 0, Skipped: 6, Time elapsed: 44.14 s <<< FAILURE! -- in org.apache.drill.exec.store.splunk.SplunkPluginTest
Error:  org.apache.drill.exec.store.splunk.SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery -- Time elapsed: 1.581 s <<< FAILURE!
org.junit.ComparisonFailure: 1:0 expected:<[Dispatch]> but was:<[KVStoreOperationStats]>
	at org.apache.drill.test.rowSet.RowSetComparison.verifyScalar(RowSetComparison.java:364)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyColumn(RowSetComparison.java:309)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyRow(RowSetComparison.java:298)
	at org.apache.drill.test.rowSet.RowSetComparison.verify(RowSetComparison.java:261)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyAndClearAll(RowSetComparison.java:285)
	at org.apache.drill.test.rowSet.RowSetUtilities.verify(RowSetUtilities.java:306)
	at org.apache.drill.exec.store.splunk.SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery(SplunkPluginTest.java:205)
	at java.base/java.lang.Thread.run(Thread.java:840)

Error:  org.apache.drill.exec.store.splunk.SplunkPluginTest.testFilterOnUnProjectedColumnQuery -- Time elapsed: 0.234 s <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<0>
	at org.apache.drill.test.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:553)
	at org.apache.drill.test.DrillTestWrapper.run(DrillTestWrapper.java:173)
	at org.apache.drill.test.TestBuilder.go(TestBuilder.java:145)
	at org.apache.drill.exec.store.splunk.SplunkPluginTest.testFilterOnUnProjectedColumnQuery(SplunkPluginTest.java:245)
	at java.base/java.lang.Thread.run(Thread.java:840)

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery:205 1:0 expected:<[Dispatch]> but was:<[KVStoreOperationStats]>
Error:    SplunkPluginTest.testFilterOnUnProjectedColumnQuery:245 expected:<3> but was:<0>
[INFO] 
Error:  Tests run: 47, Failures: 2, Errors: 0, Skipped: 7

@cgivre
Copy link
Contributor

cgivre commented Dec 26, 2024

@cgivre the Splunk tests are failing and I don't think the PR changes here are the cause.

OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Error:  Tests run: 16, Failures: 2, Errors: 0, Skipped: 6, Time elapsed: 44.14 s <<< FAILURE! -- in org.apache.drill.exec.store.splunk.SplunkPluginTest
Error:  org.apache.drill.exec.store.splunk.SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery -- Time elapsed: 1.581 s <<< FAILURE!
org.junit.ComparisonFailure: 1:0 expected:<[Dispatch]> but was:<[KVStoreOperationStats]>
	at org.apache.drill.test.rowSet.RowSetComparison.verifyScalar(RowSetComparison.java:364)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyColumn(RowSetComparison.java:309)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyRow(RowSetComparison.java:298)
	at org.apache.drill.test.rowSet.RowSetComparison.verify(RowSetComparison.java:261)
	at org.apache.drill.test.rowSet.RowSetComparison.verifyAndClearAll(RowSetComparison.java:285)
	at org.apache.drill.test.rowSet.RowSetUtilities.verify(RowSetUtilities.java:306)
	at org.apache.drill.exec.store.splunk.SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery(SplunkPluginTest.java:205)
	at java.base/java.lang.Thread.run(Thread.java:840)

Error:  org.apache.drill.exec.store.splunk.SplunkPluginTest.testFilterOnUnProjectedColumnQuery -- Time elapsed: 0.234 s <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<0>
	at org.apache.drill.test.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:553)
	at org.apache.drill.test.DrillTestWrapper.run(DrillTestWrapper.java:173)
	at org.apache.drill.test.TestBuilder.go(TestBuilder.java:145)
	at org.apache.drill.exec.store.splunk.SplunkPluginTest.testFilterOnUnProjectedColumnQuery(SplunkPluginTest.java:245)
	at java.base/java.lang.Thread.run(Thread.java:840)

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    SplunkPluginTest.testExplicitFieldsWithOneFieldLimitQuery:205 1:0 expected:<[Dispatch]> but was:<[KVStoreOperationStats]>
Error:    SplunkPluginTest.testFilterOnUnProjectedColumnQuery:245 expected:<3> but was:<0>
[INFO] 
Error:  Tests run: 47, Failures: 2, Errors: 0, Skipped: 7

Splunk is such a steaming pile of great software.

@cgivre
Copy link
Contributor

cgivre commented Dec 27, 2024

@pjfanning I got 2 of the 3 failed test runs to pass simply by re-running. I'm not sure why but the Splunk tests are super flaky. We might just want to disable them on GitHub and run them manually before we cut a release.

@jnturton Do you have any thoughts on this?

@cgivre cgivre added the ci CI label Dec 27, 2024
@pjfanning
Copy link
Member Author

I created https://issues.apache.org/jira/browse/DRILL-8516 to investigate why the make job fails on ubuntu 24.

Would it be ok to merge this as is - it gets the CI task to pass again and DRILL-8516 can be done later?

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Thanks for this.

@cgivre cgivre merged commit 9fe9f47 into master Dec 27, 2024
13 checks passed
@pjfanning pjfanning deleted the pjfanning-patch-3 branch January 3, 2025 07:25
cgivre pushed a commit to cgivre/drill that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants