Skip to content

Comments

fix(bar): prevent bar chart overflowing the graph when using dataZoom…#21511

Merged
100pah merged 1 commit intoapache:releasefrom
akashsonune:fix/bar-and-scatter-charts-overflows
Feb 17, 2026
Merged

fix(bar): prevent bar chart overflowing the graph when using dataZoom…#21511
100pah merged 1 commit intoapache:releasefrom
akashsonune:fix/bar-and-scatter-charts-overflows

Conversation

@akashsonune
Copy link
Contributor

… filterMode none with time axis. close #19972

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 5, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the doc, the behavior of clip: true of bar series should remove the bars that are totally outside of the grid, while not clip those bars that are partially outside.

This behavior is a by-design feature for a long time and I've discussed with other committers about it and I can't persuade them into changing this. So, I'm afraid we cannot approve this PR.

@akashsonune
Copy link
Contributor Author

According to the doc, the behavior of clip: true of bar series should remove the bars that are totally outside of the grid, while not clip those bars that are partially outside.

This behavior is a by-design feature for a long time and I've discussed with other committers about it and I can't persuade them into changing this. So, I'm afraid we cannot approve this PR.

@Ovilia Understood. What if we introduce a strictClip mode option for the Bar and Scatter chart? does that make sense?

100pah
100pah previously approved these changes Feb 17, 2026
@100pah 100pah changed the base branch from master to release February 17, 2026 10:05
@100pah 100pah dismissed their stale review February 17, 2026 10:05

The base branch was changed.

@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21511@665daa6

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @100pah , we decide to accept this PR and @100pah will make some improvement based on this PR. Thanks for your contribution.

@100pah 100pah merged commit f1cca26 into apache:release Feb 17, 2026
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Feb 17, 2026

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@akashsonune
Copy link
Contributor Author

After discussing with @100pah , we decide to accept this PR and @100pah will make some improvement based on this PR. Thanks for your contribution.

@Ovilia @100pah Thank you. Can I proceed with the similar changes for the scatter chart as we are facing similar problem there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Bar Chart bars overflow out of the coordinate system

3 participants