fix:When merging cells, the data of the cells that are not displayed is not cleared#612
fix:When merging cells, the data of the cells that are not displayed is not cleared#612tmlx1990 wants to merge 6 commits intoapache:mainfrom
Conversation
# Conflicts: # fastexcel-test/src/test/java/cn/idev/excel/test/demo/read/ReadTest.java
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where merged cells in Excel retained their original data instead of being cleared, leading to incorrect total counts and visual display problems. The fix ensures that when cells are merged, only the primary cell retains data while other cells in the merged range are properly cleared.
- Added logic to clear content of non-primary cells in merged ranges
- Ensures proper data handling during cell merge operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // Iterate through the columns to clear the content of merged cells | ||
| for (int i = 0; i < columnExtend; i++) { | ||
| // Access the cell at the specified column index in the current row and set it to blank | ||
| context.getRow().getCell(columnIndex + i).setBlank(); |
There was a problem hiding this comment.
Potential NullPointerException if getCell(columnIndex + i) returns null. The cell should be created if it doesn't exist before calling setBlank().
|
It would be best to also submit the unit test code. |
This unit test uses the mergeWrite method of the WriteTest.java |
|
Please make sure all test passed. |
3 participants
Purpose of the pull request
Fixed the issue where when merging cells, the actual data was not merged and the total count was displayed incorrectly
#522
What's changed?
Effect before problem repair：
Effect after problem repair：
Checklist