-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2354: e2e tests for charge-off and contract termination trns after re-age #5317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamsaghy
merged 2 commits into
apache:develop
from
openMF:FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging
Jan 23, 2026
Merged
+1,427
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
7802df0 to
f01002e
Compare
c58dc54 to
d2f69b0
Compare
adamsaghy
reviewed
Jan 19, 2026
...n/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jan 19, 2026
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rework this whole logic:
- AdvancedPaymentScheduleTransactionProcessor should do NO changes on the ProgressiveLoanInterestScheduleModel at all!
- The action is accelerateMaturityDate executed on the model, the model is updated by the EMICalculator
- The result is read from the model and repayment installment entities are updated.
- Model is the single source of truth for calculations and interest...! -> Action executed on the model, result fetched from the model...
adamsaghy
reviewed
Jan 19, 2026
fineract-e2e-tests-runner/src/test/resources/features/LoanReAging.feature
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jan 19, 2026
...n/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java
Outdated
Show resolved
Hide resolved
d2f69b0 to
d9ac27d
Compare
Contributor
|
@oleksii-novikov-onix Please rebase. |
067b92d to
bcac742
Compare
bcac742 to
c1fc69a
Compare
c1fc69a to
15b0fe8
Compare
d7cf8f1 to
b7687cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.