Skip to content

Conversation

@MarianaDmytrivBinariks
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy
Copy link
Contributor

  Wrong value in Transactions tab of resource 116 line 5.
  Actual values in line (with the same date) are: 
  [01 April 2024, Accrual Adjustment, 0.69, 0.0, 0.69, 0.0, 0.0, 0.0, false, false] 
  Expected values in line: 
  [01 April 2024, Contract Termination, 84.55, 83.57, 0.98, 0.0, 0.0, 0.0, false, false]] 
  Expecting value to be true but was false
  	at org.apache.fineract.test.stepdef.loan.LoanStepDef.loanTransactionsTabCheck(LoanStepDef.java:2235)
  	at ✽.Loan Transactions tab has the following data:(file:///home/runner/work/fineract/fineract/fineract-e2e-tests-runner/src/test/resources/features/LoanReAgingEqualAmortization.feature:11224)
  
    When Loan Pay-off is made on "01 April 2024"                                                                                                                        # org.apache.fineract.test.stepdef.loan.LoanRepaymentStepDef.makeLoanPayOff(java.lang.String)
    Then Loan is closed with zero outstanding balance and it's all installments have obligations met                                                                    # org.apache.fineract.test.stepdef.loan.LoanStepDef.loanClosedAndInstallmentsObligationsMet()
  

@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch from 7802df0 to f01002e Compare January 12, 2026 13:32
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch 3 times, most recently from c58dc54 to d2f69b0 Compare January 15, 2026 13:33
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rework this whole logic:

  • AdvancedPaymentScheduleTransactionProcessor should do NO changes on the ProgressiveLoanInterestScheduleModel at all!
  • The action is accelerateMaturityDate executed on the model, the model is updated by the EMICalculator
  • The result is read from the model and repayment installment entities are updated.
  • Model is the single source of truth for calculations and interest...! -> Action executed on the model, result fetched from the model...

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch from d2f69b0 to d9ac27d Compare January 20, 2026 12:07
@adamsaghy
Copy link
Contributor

@oleksii-novikov-onix Please rebase.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch 5 times, most recently from 067b92d to bcac742 Compare January 22, 2026 14:41
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch from bcac742 to c1fc69a Compare January 22, 2026 15:24
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch from c1fc69a to 15b0fe8 Compare January 23, 2026 08:41
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch from d7cf8f1 to b7687cf Compare January 23, 2026 09:41
@adamsaghy adamsaghy merged commit d093a08 into apache:develop Jan 23, 2026
36 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2354/e2e-test-scenarios-with-charge-off-or-contract-termination-trns-after-re-aging branch January 23, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants