Skip to content

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Jan 16, 2026

Description

Fix Postgres syntax error by casting importDocumentId to Long
Created a unit test for the fix.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was done purely by AI (judging from the very unnecessary comments).

Pls remove the comments.

Also, the test cases don't make sense at all. You're mocking out the JDBCTemplate which is doing the parameter binding eventually. I understand the AI thought it might be the best idea to verify the mock method call but it doesn't add value.

The proper test would be to verify that the JDBCTemplate works with a real (but local) database and the parameter bindings work.

@Kengne-yvana
Copy link
Contributor Author

@galovics Thanks for the review. You are right let me fix that.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2121-importer-postgres-syntax branch from 8c693ad to 7c57711 Compare January 23, 2026 06:33
@Kengne-yvana Kengne-yvana requested a review from galovics January 23, 2026 06:36
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my concerns!

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2121-importer-postgres-syntax branch 3 times, most recently from 1191a3f to 02ff84c Compare January 23, 2026 15:34
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2121-importer-postgres-syntax branch from 02ff84c to 6f1d96f Compare January 23, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants