-
Notifications
You must be signed in to change notification settings - Fork 2.3k
FINERACT-2436: Fix Client Trends by Week or Month don't work on Postgresql #5342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FINERACT-2436: Fix Client Trends by Week or Month don't work on Postgresql #5342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to make sure FINERACT uses postgresql and MySQL when needed without breaking the code . Having the same author and path but different id. I added database-specific Liquibase contexts to ensure the correct SQL dialect is applied without affecting existing MySQL installations. This fix replaces MySQL-specific functions (WEEK, MONTHNAME) with ISO-standard functions (EXTRACT, TO_CHAR) for PostgreSQL environments, while maintaining the same author and file path for traceability.
galovics
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the reason for changing an existing changelog file?
|
@galovics I choose to add the fix to this file because that's where my research let me to which is where the reports where updated for Mysql . |
|
@Kengne-yvana I think that it is better to create a new changelog file. So then the fix will be applied as a new migration. |
|
@IOhacker thanks for your review |
|
@Kengne-yvana I hope you are better now. Please let me know once I can review the PR again :) Thank you |
|
@IOhacker yeah, Hello i am back now . Feeling much better. also i will apply all the changes today. |
…thly Trends reports
22cba44 to
8e16741
Compare
|
@IOhacker please i am waiting for your review |
adamsaghy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test case which tests whether the fixed reports are working as expected?
|
sure @adamsaghy |
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.