[FLINK-38981][table] Migrate BatchPhysicalSortMergeJoinRule to java#27476
Open
liuyongvs wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38981][table] Migrate BatchPhysicalSortMergeJoinRule to java#27476liuyongvs wants to merge 1 commit intoapache:masterfrom
liuyongvs wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
featzhang
reviewed
Jan 27, 2026
| b1 -> | ||
| b1.operand(RelNode.class) | ||
| .anyInputs())) | ||
| .withDescription("BatchPhysicalSortMergeJoinRule") |
Member
There was a problem hiding this comment.
.withDescription(
"Batch physical sort-merge join rule for equi-joins with shuffle distribution")
Member
There was a problem hiding this comment.
I think the current description is a bit too brief. It would be helpful to add more details to clearly describe what the rule does and under which conditions it applies.
snuyanzin
reviewed
Jan 27, 2026
| @Value.Enclosing | ||
| public class BatchPhysicalSortMergeJoinRule | ||
| extends RelRule<BatchPhysicalSortMergeJoinRule.BatchPhysicalSortMergeJoinRuleConfig> | ||
| implements BatchPhysicalJoinRuleBase { |
Contributor
There was a problem hiding this comment.
Can we migrate the whole hierarchy to avoid intermediate state when part is in java and part is in scala?
Contributor
Author
There was a problem hiding this comment.
@snuyanzin we can step by step. BatchPhysicalJoinRuleBase has different implementation. i will migrate it to java in later pr
github-actions
bot
added
the
community-reviewed
liuyongvs
force-pushed
the
BatchPhysicalSortMergeJoinRule
branch
from
a84c3f9 to
5fb1e37
Compare
Contributor
Author
|
@snuyanzin will you have a look again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR migrates BatchPhysicalSortMergeJoinRule to java
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation