Skip to content

chore: correct log record batch checksum bounds #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luoyuxia merged 1 commit into from
Jan 17, 2026
Merged

chore: correct log record batch checksum bounds #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions crates/fluss/src/record/arrow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ pub enum LogMagicValue {
V0 = 0,
}

// NOTE: Rust layout/offsets currently match Java only for V0.
// TODO: Add V1 layout/offsets to keep parity with Java's V1 format.
pub const CURRENT_LOG_MAGIC_VALUE: u8 = LogMagicValue::V0 as u8;

/// Value used if writer ID is not available or non-idempotent.
Expand Down Expand Up @@ -457,8 +459,7 @@ impl LogRecordBatch {

fn compute_checksum(&self) -> u32 {
let start = SCHEMA_ID_OFFSET;
let end = start + self.data.len();
crc32c(&self.data[start..end])
crc32c(&self.data[start..])
}

fn attributes(&self) -> u8 {
Expand All @@ -471,12 +472,12 @@ impl LogRecordBatch {

pub fn checksum(&self) -> u32 {
let offset = CRC_OFFSET;
LittleEndian::read_u32(&self.data[offset..offset + CRC_OFFSET])
LittleEndian::read_u32(&self.data[offset..offset + CRC_LENGTH])
Copy link
Contributor

@luoyuxia luoyuxia Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

}

pub fn schema_id(&self) -> i16 {
let offset = SCHEMA_ID_OFFSET;
LittleEndian::read_i16(&self.data[offset..offset + SCHEMA_ID_OFFSET])
LittleEndian::read_i16(&self.data[offset..offset + SCHEMA_ID_LENGTH])
}

pub fn base_log_offset(&self) -> i64 {
Expand Down Expand Up @@ -1240,6 +1241,27 @@ mod tests {
assert!(matches!(result, Err(Error::IllegalArgument { .. })));
}

#[test]
fn checksum_and_schema_id_read_minimum_header() {
// Header-only batches with record_count == 0 are valid; this covers the minimal bytes
// needed for checksum/schema_id access.
let mut data = vec![0u8; SCHEMA_ID_OFFSET + SCHEMA_ID_LENGTH];
let crc = 0xA1B2C3D4u32;
let schema_id = 42i16;
LittleEndian::write_u32(&mut data[CRC_OFFSET..CRC_OFFSET + CRC_LENGTH], crc);
LittleEndian::write_i16(
&mut data[SCHEMA_ID_OFFSET..SCHEMA_ID_OFFSET + SCHEMA_ID_LENGTH],
schema_id,
);

let batch = LogRecordBatch::new(Bytes::from(data));
assert_eq!(batch.checksum(), crc);
assert_eq!(batch.schema_id(), schema_id);

let expected = crc32c(&batch.data[SCHEMA_ID_OFFSET..]);
assert_eq!(batch.compute_checksum(), expected);
}

fn le_bytes(vals: &[u32]) -> Vec<u8> {
let mut out = Vec::with_capacity(vals.len() * 4);
for &v in vals {
Expand Down
Loading