[flink] Flink Source need to check tableId on recovery in case that table is recreated. #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able is removed and created.
Contributor
Author
|
@swuferhong @wuchong , CC |
wuchong
reviewed
Dec 26, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Could you add a IT case to verify this exception will truly been thrown to user?
I think we can add this logic at the end of org.apache.fluss.flink.source.FlinkTableSourceFailOverITCase#testRestore that re-creates test_partitioned table and restart the insert into result_table select * from test_partitioned query again.
| } | ||
| checkArgument( | ||
| tableId.equals(sourceSplitBase.getTableBucket().getTableId()), | ||
| "table id not equal across splits {}", |
Member
There was a problem hiding this comment.
Make the exception message more clear to users, what table path, what is the different table ids, why this error happens, how to resolve this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2140
Brief change log
Tests
API and Format
Documentation