Skip to content

Conversation

@sd4324530
Copy link
Contributor

Purpose

Linked issue: close #2238

Brief change log

add RuntimeContextAdapter in module fluss-flink-1.18 and fluss-flink-common

@sd4324530 sd4324530 closed this Dec 24, 2025
@sd4324530 sd4324530 reopened this Dec 24, 2025
Copy link
Contributor

@vamossagar12 vamossagar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sd4324530
Copy link
Contributor Author

@wuchong @loserwang1024 ,cc

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sd4324530 , could you add Unit Tests or Integration Tests to reproduce this issue? So that we won't break this compatibility in the future.

Others looks good to me.

@sd4324530 sd4324530 closed this Dec 28, 2025
@sd4324530 sd4324530 reopened this Dec 28, 2025
@sd4324530
Copy link
Contributor Author

@wuchong Fixd. Please take a look.

@sd4324530 sd4324530 requested a review from wuchong December 28, 2025 12:28
@wuchong
Copy link
Member

wuchong commented Dec 28, 2025

@sd4324530 thank you. Could you also add this test for flink 1.18 and flink 1.19? This helps verify the added adapter in Flink 1.18 is correct, and not adding adapter in Flink 1.19 is also correct.

Besides, could you use rebase to rebase your branch onto main branch instead of using merge? It's suggest not using "git merge" to merge branches, otherwise the changes is hard to track. Please use "git rebase" to rebase branches instead. IntelliJ IDEA provide an easy tool to do git rebase, you can find the tool via VCS -> Git -> Rebase.


@BeforeEach
@Override
void beforeEach() throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not override parent test method, otherwise, it's hard to maintain. If the Flink classes used in test are also not compatible across different Flink versions, we should do the same adapter for them (but leave them in test packages only), you can checkout ResolvedCatalogMaterializedTableAdapter for an example.

Signed-off-by: Pei Yu <125331682@qq.com>
@sd4324530 sd4324530 requested a review from wuchong December 28, 2025 23:51
@wuchong wuchong merged commit 1055e42 into apache:main Dec 29, 2025
6 checks passed
@sd4324530 sd4324530 deleted the issue-2238 branch January 4, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getRuntimeContext().getAttemptNumber() is not founded in flink 2.1

3 participants