feat(python): add buffer index accessors #3223
Merged
+104
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
requested review from
LiangliangSui,
pandalee99,
theweipeng and
urlyy
urlyy
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Buffer index access is currently exposed as Python properties. This change standardizes access through explicit getters/setters to make call sites uniform across Cython and Python and avoid property usage.
What does this PR do?
get_reader_index/set_reader_indexandget_writer_index/set_writer_indexonBuffer.reader_index/writer_indexproperty usage across Python and Cython code paths.Related issues
None.
Does this PR introduce any user-facing change?
Yes. Python
Bufferindex access now uses explicit get/set methods instead of properties.Benchmark
Not run (not requested).