Skip to content

Conversation

@haridsv
Copy link
Contributor

@haridsv haridsv commented Nov 12, 2025

This PR implements the rest of the planned key management APIs and adds full test coverage for these APIs. It also fixes a few bugs and other minor issues and also makes some generic code quality improvements on top of the open PR #7421.

HBASE-29666

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 3m 31s HBASE-29368-key-management-feature passed
+1 💚 compile 6m 50s HBASE-29368-key-management-feature passed
+1 💚 checkstyle 3m 3s HBASE-29368-key-management-feature passed
+1 💚 spotbugs 6m 44s HBASE-29368-key-management-feature passed
+1 💚 spotless 0m 48s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 2s the patch passed
+1 💚 compile 6m 44s the patch passed
+1 💚 cc 6m 44s the patch passed
-0 ⚠️ javac 0m 43s /results-compile-javac-hbase-common.txt hbase-common generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 9s The patch passed checkstyle in hbase-protocol-shaded
+1 💚 checkstyle 0m 14s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 19s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 1m 0s hbase-server: The patch generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)
+1 💚 checkstyle 1m 11s The patch passed checkstyle in hbase-thrift
+1 💚 checkstyle 0m 8s The patch passed checkstyle in hbase-shell
-0 ⚠️ rubocop 0m 28s /results-rubocop.txt The patch generated 15 new + 44 unchanged - 1 fixed = 59 total (was 45)
+1 💚 spotbugs 7m 3s the patch passed
+1 💚 hadoopcheck 11m 57s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 hbaseprotoc 2m 48s the patch passed
-1 ❌ spotless 0m 41s patch has 23 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
67m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7460
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop
uname Linux f684051410a6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 491035b
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s HBASE-29368-key-management-feature passed
+1 💚 compile 2m 55s HBASE-29368-key-management-feature passed
+1 💚 javadoc 1m 49s HBASE-29368-key-management-feature passed
+1 💚 shadedjars 6m 16s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 19s the patch passed
+1 💚 compile 2m 55s the patch passed
+1 💚 javac 2m 55s the patch passed
+1 💚 javadoc 0m 10s hbase-protocol-shaded in the patch passed.
-0 ⚠️ javadoc 0m 16s /results-javadoc-javadoc-hbase-common.txt hbase-common generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
+1 💚 javadoc 0m 16s hbase-client in the patch passed.
+1 💚 javadoc 0m 27s hbase-server generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65)
+1 💚 javadoc 0m 31s hbase-thrift in the patch passed.
+1 💚 javadoc 0m 10s hbase-shell in the patch passed.
+1 💚 shadedjars 6m 14s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 57s hbase-common in the patch passed.
+1 💚 unit 1m 29s hbase-client in the patch passed.
-1 ❌ unit 231m 17s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 6m 48s hbase-thrift in the patch passed.
+1 💚 unit 6m 53s hbase-shell in the patch passed.
286m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7460
Optional Tests javac javadoc unit compile shadedjars
uname Linux 3d85a6ebed63 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29368-key-management-feature / 491035b
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/testReport/
Max. process+thread count 4402 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7460/9/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@haridsv haridsv marked this pull request as ready for review November 28, 2025 02:09
@virajjasani
Copy link
Contributor

There are few spotless warnings that can be taken care of later in the final PR

@virajjasani virajjasani merged commit ffc1743 into apache:HBASE-29368-key-management-feature Nov 28, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants