Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 5, 2026

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Member

@junegunn junegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the comment here to drop the phrase "exactly once per implementation" to avoid future confusion:

/**
* Initializes the implementation with configuration and a set of providers available. This method
* should be called exactly once per implementation prior to calling
* {@link #selectProvider(String, User)}.
*/

@Apache-HBase

This comment has been minimized.

@Apache9
Copy link
Contributor Author

Apache9 commented Jan 6, 2026

The failed UTs have some problem and maybe the PR here changed something and cause them to fail...

After digging, the problem is that, we want to hack InetAddress for the testing, but for hostname like localhost, we will always return the same InetAddress instance, so the hack in one method may affect other method and cause trouble...

Plan to rewrite the failed two methods to make them more stable.

Thanks.

@Apache-HBase

This comment has been minimized.

@Apache9
Copy link
Contributor Author

Apache9 commented Jan 6, 2026

We should update the comment here to drop the phrase "exactly once per implementation" to avoid future confusion:

/**
* Initializes the implementation with configuration and a set of providers available. This method
* should be called exactly once per implementation prior to calling
* {@link #selectProvider(String, User)}.
*/

I modified the comment, PTAL.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Member

@junegunn junegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Apache9 Apache9 self-assigned this Jan 7, 2026
@Apache9 Apache9 requested a review from NihalJain January 7, 2026 11:00
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 9s master passed
+1 💚 compile 5m 54s master passed
+1 💚 checkstyle 1m 47s master passed
+1 💚 spotbugs 3m 23s master passed
+1 💚 spotless 0m 48s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 6s the patch passed
+1 💚 compile 5m 45s the patch passed
-0 ⚠️ javac 0m 50s /results-compile-javac-hbase-client.txt hbase-client generated 2 new + 125 unchanged - 3 fixed = 127 total (was 128)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 47s the patch passed
+1 💚 spotbugs 3m 54s the patch passed
+1 💚 hadoopcheck 12m 17s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 47s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
52m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7588
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 14eedbe4e32a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8a6816c
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 25s master passed
+1 💚 compile 2m 3s master passed
+1 💚 javadoc 1m 19s master passed
+1 💚 shadedjars 6m 2s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 javadoc 1m 15s the patch passed
+1 💚 shadedjars 5m 58s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 2m 22s hbase-common in the patch passed.
+1 💚 unit 1m 31s hbase-client in the patch passed.
-1 ❌ unit 236m 53s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 19m 27s hbase-mapreduce in the patch passed.
293m 0s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7588
Optional Tests javac javadoc unit compile shadedjars
uname Linux bf1f61fea52e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8a6816c
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/testReport/
Max. process+thread count 4447 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7588/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jan 14, 2026

The failed UTs are not related.

Let me merge.

@Apache9 Apache9 merged commit 19c9d33 into apache:master Jan 14, 2026
1 check failed
Apache9 added a commit that referenced this pull request Jan 14, 2026
…try (#7588)

Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit 19c9d33)
Apache9 added a commit to Apache9/hbase that referenced this pull request Jan 14, 2026
…try (apache#7588)

Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit 19c9d33)
Apache9 added a commit that referenced this pull request Jan 15, 2026
…try (#7588) (#7624)

(cherry picked from commit 19c9d33)

Signed-off-by: Junegunn Choi <junegunn@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants