HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile … #7613

Apache9 · 2026-01-10T14:05:02Z

…test

Apache9 · 2026-01-10T14:06:35Z

After investigating, I found that the only problem is a typo...

We should use recoveredBucketCache instead of BucketCache here...

And also did some simple changes to cleanup the warnings in BucketCache.

@wchevreuil PTAL. This is only 100% fail test for now...

Apache-HBase · 2026-01-10T14:57:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 31s		master passed
+1 💚	compile	3m 34s		master passed
+1 💚	checkstyle	1m 0s		master passed
+1 💚	spotbugs	1m 43s		master passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 14s		the patch passed
+1 💚	compile	3m 27s		the patch passed
+1 💚	javac	3m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 59s		the patch passed
+1 💚	spotbugs	1m 45s		the patch passed
+1 💚	hadoopcheck	12m 18s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 47s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		41m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7613
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 04c8e8e08559 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cae55e9`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-10T18:37:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 17s		master passed
+1 💚	compile	0m 58s		master passed
+1 💚	javadoc	0m 29s		master passed
+1 💚	shadedjars	5m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	5m 59s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	234m 17s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		261m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7613
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9843de439157 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cae55e9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/1/testReport/
Max. process+thread count	4225 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Umeshkumar9414 · 2026-01-10T20:06:48Z

...-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestVerifyBucketCacheFile.java

 * Basic test for check file's integrity before start BucketCache in fileIOEngine
 */
 @RunWith(Parameterized.class)
 @Category(SmallTests.class)


Almost each test method is waiting for cache initialization with 10 second timeout. Do you think we can still keep it in SmallTest category ?

I guess this is just for increasing stability, since we do not need to start a mini cluster, the test can finish within 30 seconds.

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java

mnpoonia · 2026-01-11T16:24:43Z

...-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestVerifyBucketCacheFile.java

          constructedBlockSizes, writeThreads, writerQLen, testDir + "/bucket.persistence");
-      waitPersistentCacheValidation(conf, bucketCache);
+      assertTrue(recoveredBucketCache.waitForCacheInitialization(10000));
+      waitPersistentCacheValidation(conf, recoveredBucketCache);


Is this the main fix. We were using a bucketCache which is deleted instead of the recoveredBucketCache?

Yes, just a typo... We should recoveredBucketCache instead of bucketCache here...

…cket/BucketCache.java Co-authored-by: Aman Poonia <aman.poonia.29@gmail.com>

Apache-HBase · 2026-01-12T08:53:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 5s		master passed
+1 💚	compile	2m 35s		master passed
+1 💚	checkstyle	0m 47s		master passed
+1 💚	spotbugs	1m 21s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 17s		the patch passed
+1 💚	compile	2m 34s		the patch passed
+1 💚	javac	2m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 44s		the patch passed
+1 💚	spotbugs	1m 18s		the patch passed
+1 💚	hadoopcheck	8m 25s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 33s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 8s		The patch does not generate ASF License warnings.
		30m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7613
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9b10b8c3fe1f 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2713bcf`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-12T13:34:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 39s		master passed
+1 💚	compile	1m 13s		master passed
+1 💚	javadoc	0m 31s		master passed
+1 💚	shadedjars	6m 2s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s		the patch passed
+1 💚	compile	1m 3s		the patch passed
+1 💚	javac	1m 3s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	6m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	280m 50s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		310m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7613
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 27a7665137c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2713bcf`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/2/testReport/
Max. process+thread count	3660 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7613/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2026-01-12T15:31:39Z

Ping @wchevreuil

HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile …

cae55e9

…test

Apache9 requested a review from wchevreuil January 10, 2026 14:05

Apache9 self-assigned this Jan 10, 2026

Umeshkumar9414 reviewed Jan 10, 2026

View reviewed changes

mnpoonia reviewed Jan 11, 2026

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java Outdated Show resolved Hide resolved

mnpoonia reviewed Jan 11, 2026

View reviewed changes

Update hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bu…

2713bcf

…cket/BucketCache.java Co-authored-by: Aman Poonia <aman.poonia.29@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile … #7613

HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile … #7613

Uh oh!

Apache9 commented Jan 10, 2026

Uh oh!

Apache9 commented Jan 10, 2026

Uh oh!

Apache-HBase commented Jan 10, 2026

Uh oh!

Apache-HBase commented Jan 10, 2026

Uh oh!

Umeshkumar9414 Jan 10, 2026 •

edited

Loading

Uh oh!

Apache9 Jan 12, 2026

Uh oh!

Uh oh!

mnpoonia Jan 11, 2026 •

edited

Loading

Uh oh!

Apache9 Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

Apache9 commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile … #7613

Are you sure you want to change the base?

HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile … #7613

Uh oh!

Conversation

Apache9 commented Jan 10, 2026

Uh oh!

Apache9 commented Jan 10, 2026

Uh oh!

Apache-HBase commented Jan 10, 2026

Uh oh!

Apache-HBase commented Jan 10, 2026

Uh oh!

Umeshkumar9414 Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mnpoonia Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache9 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

Apache9 commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Umeshkumar9414 Jan 10, 2026 •

edited

Loading

mnpoonia Jan 11, 2026 •

edited

Loading