HIVE-29387:upgrade commons-lang3 to 3.20.x to fix CVE-2025-48924#6251
HIVE-29387:upgrade commons-lang3 to 3.20.x to fix CVE-2025-48924#6251ramitg254 wants to merge 3 commits intoapache:masterfrom
Conversation
c382c90 to
2b74140
Compare
ayushtkn
left a comment
There was a problem hiding this comment.
@ramitg254 can you check if there are other versions getting packaged as well
+- commons-lang:commons-lang:jar:2.6:compile
I think hadoop & tez are pulling in other versions
2b74140 to
b83242a
Compare
This reverts commit b83242a.
this pr only addresses the dependency but since you mentioned the |
|
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>${commons-lang3.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
why are you adding a dependency in scope of upgrading one?
There was a problem hiding this comment.
commons-lang3 of version 3.17.0 was brought in transitively via hadoop so adding it in dependency management to ensure only newer version should be present as storage-api do not define hive pom as parent and has parent
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>35</version>
</parent>
|
@ramitg254 , I understand and totally get why these changes are made but I'm not in favour of such changes because it invites I just wanted to express my concerns, I won't be in way if other PMC/committers are ok with this approach. |
Thanks @Aggarwal-Raghav for sharing the concern, so based on what I understood I think we can do either of two things here:
|



What changes were proposed in this pull request?
commons-lang3 upgraded to 3.20.0
Why are the changes needed?
It fixes CVE-2025-48924
Does this PR introduce any user-facing change?
No
How was this patch tested?
build locally and ci tests