-
Notifications
You must be signed in to change notification settings - Fork 984
Content coding support #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arturobernalg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7dbbd2d to
71fc36c
Compare
@arturobernalg I made a mistake. Good catch. Please take another look. |
arturobernalg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Funny that this popped up because I am new to using the HTTP5 library, and the HttpEntity.getContent() Javadoc does not say if you get back the encoded stream, or (better) a decoded stream. Does this PR implement a best effort for making HttpEntity.getContext() do the latter? If so, the Javadoc for that function should be clarified. |
@rpkrajewski The classic HttpClient has had support for the transparent content decompression for quite some time. Recently this support has also been added to the async HttpClient. As to whether an entity content is encoded this is determined by the |
|
Thanks - I will experiment more with this when 5.6 is out. |
Relatively minor code optimization that improves consistency of automatic content decompression by the classic and async transports. @arturobernalg Please double-check.