perf: Avoid re-fetching file status from FS for HFile readers #17709
+24
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-other-tim-brown
changed the title
yihua
reviewed
Dec 24, 2025
| byte[] buffer; | ||
| try (SeekableDataInputStream stream = storage.openSeekable(path, false)) { | ||
| buffer = new byte[(int) storage.getPathInfo(path).getLength()]; | ||
| buffer = new byte[(int) fileSize]; |
Contributor
There was a problem hiding this comment.
For an inline path (inlinefs:), this represents the log block size instead of the full log file size. Will that be a problem?
Contributor
Author
There was a problem hiding this comment.
Is there a path that executes this that I can run locally?
Contributor
Author
There was a problem hiding this comment.
@yihua let me know if there is a particular path I can step through to validate this
the-other-tim-brown
force-pushed
the
hfile-reader-file-listing
branch
2 times, most recently
from
e541da6 to
63382d5
Compare
the-other-tim-brown
force-pushed
the
hfile-reader-file-listing
branch
from
63382d5 to
14751d0
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
The HFile readers are looking up the file length when the code supplies a path to read. We often know the length for the reader upfront so we should avoid looking this up again.
Summary and Changelog
Impact
Improves performance when dealing with remote filesystems like S3/GCS
Risk Level
Low, functionality is covered by existing tests
Documentation Update
Contributor's checklist