-
Notifications
You must be signed in to change notification settings - Fork 76
feat: enhance ManifestReader with projection and filtering support #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,755
−764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
537a136 to
d4f7c24
Compare
d4f7c24 to
81b1732
Compare
wgtmac
commented
Dec 23, 2025
- Consolidate `ManifestReader` implementation into `manifest_reader.cc` and remove `manifest_reader_internal.cc`. - Implement fluent API for column selection, partition filtering, and row filtering. - Support lazy initialization of the underlying Avro reader. - Add various filtering support for entries.
81b1732 to
5b11c46
Compare
WZhuo
reviewed
Dec 23, 2025
WZhuo
reviewed
Dec 23, 2025
HuaHuaY
reviewed
Dec 23, 2025
WZhuo
reviewed
Dec 23, 2025
zhjwpku
reviewed
Dec 23, 2025
shangxinli
reviewed
Dec 23, 2025
shangxinli
reviewed
Dec 23, 2025
shangxinli
reviewed
Dec 23, 2025
shangxinli
reviewed
Dec 24, 2025
shangxinli
reviewed
Dec 24, 2025
shangxinli
reviewed
Dec 24, 2025
Member
Author
|
Thanks for the review! I have addressed all comments. Let me know what you think. @WZhuo @zhjwpku @HuaHuaY @shangxinli |
zhjwpku
approved these changes
Dec 24, 2025
HuaHuaY
reviewed
Dec 24, 2025
HuaHuaY
approved these changes
Dec 24, 2025
shangxinli
approved these changes
Dec 24, 2025
liurenjie1024
approved these changes
Dec 25, 2025
Member
Author
|
Thanks all for the review! Let me merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
ManifestReaderimplementation to support advanced data skippingand projection pushdown, and adds full test coverage ported from the Java implementation.
Implementation Changes:
ManifestReaderlogic: Move implementation frommanifest_reader_internal.ccto
manifest_reader.ccand remove the obsolete internal class.Select(),FilterPartitions(), andFilterRows()to supportcolumn projection and expression-based filtering (partition & metrics).
Test Coverage:
manifest_reader_test.cc: PortsTestManifestReaderfrom Java, covering:manifest_reader_stats_test.cc: PortsTestManifestReaderStats, verifying: