feat: Impl LocationProvider #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WZhuo
force-pushed
the
location_provider
branch
from
1aee659 to
932bd2c
Compare
WZhuo
force-pushed
the
location_provider
branch
from
932bd2c to
d855a40
Compare
wgtmac
reviewed
Jan 4, 2026
src/iceberg/location_provider.h
Outdated
| /// \param filename a file name | ||
| /// \return a fully-qualified location URI for a data file | ||
| /// | ||
| /// TODO(wgtmac): StructLike is not well thought yet, we may wrap an ArrowArray |
src/iceberg/location_provider.h
Outdated
| /// \param input_location the table location | ||
| /// \param properties the table properties | ||
| /// \return a LocationProvider instance | ||
| static Result<std::unique_ptr<LocationProvider>> For(const std::string& input_location, |
Member
There was a problem hiding this comment.
Use Make to be consistent with other APIs.
src/iceberg/expression/literal.cc
Outdated
| .value_or("invalid literal of type decimal"); | ||
| } | ||
| case TypeId::kString: { | ||
| // TODO(zhuo.wang): escape string? |
Member
There was a problem hiding this comment.
IMO ToString is for human readable representation. So it is no need to escape it here?
src/iceberg/location_provider.h
Outdated
| /// system. | ||
| class ICEBERG_EXPORT DefaultLocationProvider : public LocationProvider { | ||
| public: | ||
| DefaultLocationProvider(const std::string& table_location, |
Member
There was a problem hiding this comment.
Should we use std::string_view for table_location?
src/iceberg/location_provider.h
Outdated
|
|
||
| Result<std::string> NewDataLocation(const PartitionSpec& spec, | ||
| const PartitionValues& partition_data, | ||
| const std::string& filename) override; |
Member
There was a problem hiding this comment.
Same question for filename to use string_view in both NewDataLocation functions. We can change the base class function signature if appropriate.
src/iceberg/location_provider.cc
Outdated
| std::string DirsFromHash(int32_t hash) { | ||
| std::string hash_with_dirs; | ||
|
|
||
| for (int i = 0; i < kEntropyDirDepth * kEntropyDirLength; i += kEntropyDirLength) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < kEntropyDirDepth * kEntropyDirLength; i += kEntropyDirLength) { | |
| for (int32_t i = 0; i < kEntropyDirDepth * kEntropyDirLength; i += kEntropyDirLength) { |
src/iceberg/location_provider.cc
Outdated
| } | ||
|
|
||
| std::string PathContext(std::string_view table_location) { | ||
| std::string path = LocationUtil::StripTrailingSlash(table_location); |
Member
There was a problem hiding this comment.
If StripTrailingSlash returns a string_view, we can avoid creating a string object here.
src/iceberg/location_provider.cc
Outdated
|
|
||
| size_t last_slash = path.find_last_of('/'); | ||
| if (last_slash != std::string::npos && last_slash < path.length() - 1) { | ||
| std::string_view data_path(path.data(), path.size() - last_slash - 1); |
Member
There was a problem hiding this comment.
Suggested change
| std::string_view data_path(path.data(), path.size() - last_slash - 1); | |
| std::string_view data_path = std::string_view(path).substr(last_slash + 1); |
src/iceberg/location_provider.h
Outdated
|
|
||
| /// \brief DefaultLocationProvider privides default location provider for local file | ||
| /// system. | ||
| class ICEBERG_EXPORT DefaultLocationProvider : public LocationProvider { |
Member
There was a problem hiding this comment.
It seems that we can move these impl classes to location_provider.cc without declaring them here.
| Result<std::unique_ptr<StructType>> PartitionType(const Schema& schema) const; | ||
|
|
||
| /// \brief Get the partition path for the given partition data. | ||
| Result<std::string> PartitionPath(const PartitionValues& data) const; |
Member
There was a problem hiding this comment.
Can we add some test cases for this? This function can also be in a separate PR if you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.