feat: implement reference visitor #491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
reviewed
Jan 10, 2026
|
|
||
| Result<FieldIdsSetRef> ReferenceVisitor::Predicate( | ||
| [[maybe_unused]] const std::shared_ptr<UnboundPredicate>& pred) { | ||
| return referenced_field_ids_; |
Collaborator
There was a problem hiding this comment.
Should we error on unbound predicates and unbound aggregates? ISTM that an expression should be either fully bound or fully unbound, and that mixing the two is not possible, and visiting an unbound expression would be meaningless.
Collaborator
There was a problem hiding this comment.
I just took a look at the Java's impl of ReferenceVisitor and IsBoundVisitor, it appears that mixed bound and unbound predicate should error, I created PR #503 to fix our IsBoundVisitor logic, please correct me if f I'm wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.