feat: Add factory functions for ManifestWriter and ManifestListWriter #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhjwpku
commented
Jan 7, 2026
zhjwpku
commented
- Add ManifestWriter::MakeWriter() factory function that takes format_version parameter and routes to appropriate MakeV1Writer/MakeV2Writer/MakeV3Writer
- Add ManifestListWriter::MakeWriter() factory function with same pattern
- Update test cases to use the new factory functions instead of scattered if-else chains checking format_version
- Centralizes version handling logic, making it easier to add v4, v5, etc. in the future
…iter - Add ManifestWriter::MakeWriter() factory function that takes format_version parameter and routes to appropriate MakeV1Writer/MakeV2Writer/MakeV3Writer - Add ManifestListWriter::MakeWriter() factory function with same pattern - Update test cases to use the new factory functions instead of scattered if-else chains checking format_version - Centralizes version handling logic, making it easier to add v4, v5, etc. in the future
zhjwpku
force-pushed
the
introduce_writer_factory_function
branch
from
693c8be to
73e71b8
Compare
zhjwpku
changed the title
zhjwpku
force-pushed
the
introduce_writer_factory_function
branch
from
21c9f11 to
1b49fe0
Compare
wgtmac
reviewed
Jan 8, 2026
| std::string_view manifest_location, std::shared_ptr<FileIO> file_io, | ||
| std::shared_ptr<PartitionSpec> partition_spec, | ||
| std::shared_ptr<Schema> current_schema, | ||
| std::optional<ManifestContent> content = std::nullopt, |
Member
There was a problem hiding this comment.
It seems that ManifestContent content = ManifestContent::kData is a better option?
wgtmac
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.