Skip to content

PR #1169 #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JE-Chen wants to merge 6 commits into from
Closed

PR #1169 #1206

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c52bf9
Add ns TimeType
JE-Chen Sep 25, 2024
b3e83cf
Remove ns raise TypeError test, because it will no longer raise a Typ…
JE-Chen Sep 25, 2024
ee3cd59
Revert "Remove ns raise TypeError test, because it will no longer rai…
JE-Chen Sep 25, 2024
a031c0d
Add downcast condition on Time64Type
JE-Chen Sep 26, 2024
37c8198
Return TImeType not raise error here
JE-Chen Oct 1, 2024
2c92638
ruff reformat
JE-Chen Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,8 +1068,14 @@ def primitive(self, primitive: pa.DataType) -> PrimitiveType:
return StringType()
elif pa.types.is_date32(primitive):
return DateType()
elif isinstance(primitive, pa.Time64Type) and primitive.unit == "us":
return TimeType()
elif isinstance(primitive, pa.Time64Type):
if primitive.unit == "us":
return TimeType()
elif primitive.unit == "ns":
if self._downcast_ns_timestamp_to_us:
logger.warning("Iceberg does not yet support 'ns' timestamp precision. Downcasting to 'us'.")
else:
return TimeType()
elif pa.types.is_timestamp(primitive):
primitive = cast(pa.TimestampType, primitive)
if primitive.unit in ("s", "ms", "us"):
Expand Down