Allow upserting into an empty table #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-upsert-empty-table
branch
from
4817b00 to
a7501a0
Compare
kevinjqliu
approved these changes
Feb 21, 2025
Comment on lines
+582
to
+584
| if overwrite_filter != AlwaysFalse(): | ||
| # Only delete when the filter is != AlwaysFalse | ||
| self.delete(delete_filter=overwrite_filter, case_sensitive=case_sensitive, snapshot_properties=snapshot_properties) |
Contributor
There was a problem hiding this comment.
i thought self.delete is a no-op when the overwrite_filter is AlwaysFalse, but i like that its more explicit here 👍
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
When you upsert into an empty table, it fails because it tries to search for records to be updated 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you upsert into an empty table, it fails because it tries to search for records to be updated 🤔