Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Mar 4, 2025

For the tests, we want to limit parallelism to avoid creating 1-row Parquet files.

For the tests, we want to limit parallelism to avoid creating 1-row Parquet files.
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We previously added this config in dev/provision.py

# The configuration is important, otherwise we get many small
# parquet files with a single row. When a positional delete
# hits the Parquet file with one row, the parquet file gets
# dropped instead of having a merge-on-read delete file.
spark = (
SparkSession
.builder
.config("spark.sql.shuffle.partitions", "1")
.config("spark.default.parallelism", "1")
.getOrCreate()
)

and looks like these are the only two places where we create SparkSession
https://grep.app/search?f.repo.pattern=iceberg-python&q=getOrCreate%28%29

@kevinjqliu kevinjqliu merged commit e3a5c3b into main Mar 4, 2025
7 checks passed
@kevinjqliu kevinjqliu deleted the fd-config branch March 4, 2025 22:48
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
For the tests, we want to limit parallelism to avoid creating 1-row
Parquet files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants