Add pull-request template #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Mar 11, 2025
kevinjqliu
reviewed
Mar 11, 2025
Contributor
There was a problem hiding this comment.
Need the Apache license headers in the file.
Contributor
Author
There was a problem hiding this comment.
Since we don't include the .github/* directory in the source release tar, we can ignore this. I don't like that people have to scroll across the license.
Contributor
|
Thanks! This should make summarizing the release note easier |
| @@ -1,3 +1,4 @@ | |||
| .github/* | |||
Member
There was a problem hiding this comment.
It's very strange, how .github/* worked and .github/pull_request_template.md didn't 🤔
kevinjqliu
approved these changes
Mar 15, 2025
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
While @kevinjqliu did an amazing job summarizing the new stuff in 0.9.0 in the GitHub release (https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.9.0), I think it would be good to formalize this a bit. This also came up in apache#1669 where we introduced a behavioral change. cc @sungwy I think it would be good to allow users to populate the changelog section to ensure they know about any relevant changes. The template is pretty minimal now to avoid being a big barrier to opening a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While @kevinjqliu did an amazing job summarizing the new stuff in 0.9.0 in the GitHub release (https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.9.0), I think it would be good to formalize this a bit.
This also came up in #1669 where we introduced a behavioral change. cc @sungwy
I think it would be good to allow users to populate the changelog section to ensure they know about any relevant changes.
The template is pretty minimal now to avoid being a big barrier to opening a PR.