feat: check whether table ops conflict when committing #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Mar 19, 2025
Fokko
reviewed
Mar 19, 2025
Fokko
reviewed
Mar 20, 2025
pyiceberg/table/update/snapshot.py
Outdated
Comment on lines
248
to
249
| except Exception: | ||
| return self._transaction._table.metadata |
Contributor
There was a problem hiding this comment.
Any specific reason to swallow this exception? If there are any errors, I think it is likely that the commit will fail as well.
Fokko
reviewed
Mar 20, 2025
Comment on lines
+466
to
+467
| if snapshot is None: | ||
| raise CommitFailedException("Snapshot cannot be None.") |
Contributor
There was a problem hiding this comment.
I think this is not correct. When you create an empty table, there is no current-snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check whether table ops conflict when committing
related to #1678
Rationale for this change
Are these changes tested?
Are there any user-facing changes?