Skip to content

nit: Clean up import in conftest.py #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Mar 25, 2025
Merged

nit: Clean up import in conftest.py #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import pytest
from moto import mock_aws

from pyiceberg import schema
from pyiceberg.catalog import Catalog, load_catalog
from pyiceberg.catalog.noop import NoopCatalog
from pyiceberg.expressions import BoundReference
Expand Down Expand Up @@ -140,7 +139,7 @@ def pytest_addoption(parser: pytest.Parser) -> None:

@pytest.fixture(scope="session")
def table_schema_simple() -> Schema:
return schema.Schema(
return Schema(
NestedField(field_id=1, name="foo", field_type=StringType(), required=False),
NestedField(field_id=2, name="bar", field_type=IntegerType(), required=True),
NestedField(field_id=3, name="baz", field_type=BooleanType(), required=False),
Expand All @@ -151,7 +150,7 @@ def table_schema_simple() -> Schema:

@pytest.fixture(scope="session")
def table_schema_with_full_nested_fields() -> Schema:
return schema.Schema(
return Schema(
NestedField(
field_id=1,
name="foo",
Expand Down Expand Up @@ -180,7 +179,7 @@ def table_schema_with_full_nested_fields() -> Schema:

@pytest.fixture(scope="session")
def table_schema_nested() -> Schema:
return schema.Schema(
return Schema(
NestedField(field_id=1, name="foo", field_type=StringType(), required=False),
NestedField(field_id=2, name="bar", field_type=IntegerType(), required=True),
NestedField(field_id=3, name="baz", field_type=BooleanType(), required=False),
Expand Down Expand Up @@ -231,7 +230,7 @@ def table_schema_nested() -> Schema:

@pytest.fixture(scope="session")
def table_schema_nested_with_struct_key_map() -> Schema:
return schema.Schema(
return Schema(
NestedField(field_id=1, name="foo", field_type=StringType(), required=True),
NestedField(field_id=2, name="bar", field_type=IntegerType(), required=True),
NestedField(field_id=3, name="baz", field_type=BooleanType(), required=False),
Expand Down Expand Up @@ -303,7 +302,7 @@ def table_schema_nested_with_struct_key_map() -> Schema:

@pytest.fixture(scope="session")
def table_schema_with_all_types() -> Schema:
return schema.Schema(
return Schema(
NestedField(field_id=1, name="boolean", field_type=BooleanType(), required=True),
NestedField(field_id=2, name="integer", field_type=IntegerType(), required=True),
NestedField(field_id=3, name="long", field_type=LongType(), required=True),
Expand Down