-
Notifications
You must be signed in to change notification settings - Fork 414
Introduce AuthManager #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AuthManager #1908
Conversation
|
|
||
| # Download AWS bundle | ||
| RUN curl --retry 5 -s https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-aws-bundle/1.9.0-SNAPSHOT/iceberg-aws-bundle-1.9.0-20250408.002722-86.jar \ | ||
| RUN curl --retry 5 -s https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-aws-bundle/1.9.0-SNAPSHOT/iceberg-aws-bundle-1.9.0-20250409.002731-88.jar \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The older version of the iceberg-aws-bundle looks like it was removed. Updating the pin to fix issues with the integration tests: https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-aws-bundle/1.9.0-SNAPSHOT/
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sungwy for working on this in PyIceberg 🙌 I think it would be good to separate the auth code from the general REST code 👍
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
apache#1906
# Are these changes tested?
Yes, unit tested
# Are there any user-facing changes?
Not yet
<!-- In the case of user-facing changes, please add the changelog label.
-->
Rationale for this change
#1906
Are these changes tested?
Yes, unit tested
Are there any user-facing changes?
Not yet