Changes to support string transform in add_field. #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
kevinjqliu
approved these changes
Apr 19, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
split nit about moving the function
| return literal(func(lit.value)) | ||
|
|
||
|
|
||
| def parse_transform(v: Any) -> Any: |
Contributor
There was a problem hiding this comment.
is this intentional? seems like the function got moved lower
Contributor
Author
There was a problem hiding this comment.
@kevinjqliu yes this is intentional.
I had to re-position the parse_transform method to change the return type of the method from Any to Transform[Any, Any] because mypy wasn't happy after we made Transform type as Union[str, Transform] in add_field. Without moving it down, Transform wasn't being recognized in the code.
Contributor
|
Thanks @guptaakashdeep |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Closes apache#1882 # Rationale for this change Feature request: Ability to pass transform name as string in `add_fields` # Are these changes tested? Yes # Are there any user-facing changes? Yes. Users will be able to pass transform names as string while calling add_fields method of update_spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1882
Rationale for this change
Feature request: Ability to pass transform name as string in
add_fieldsAre these changes tested?
Yes
Are there any user-facing changes?
Yes. Users will be able to pass transform names as string while calling add_fields method of update_spec.