Build: Decouple setup and exec in integration tests for better flexibility #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
May 10, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! I like this. Sometimes i want just the infrastructure to test against other things :)
Contributor
|
Thanks for the contribution @frankliee |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
…ility (apache#1985) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Decouple setup and exec in integration tests for better flexibility and isolation. For example, currently, `make test-integration` must be executed in a physical server. It is because `docker xxx` cannot be executed within a container (docker in docker is out of scope of this PR). Sometimes, it is useful for local debugging, as poetry cannot provide system level isolation, includes environment variables and shared libs. This PR allows us to run `make test-integration-exec` within a container environment, after we have run `make test-integration-setup` on this server. # Are these changes tested? Existing tests. # Are there any user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Decouple setup and exec in integration tests for better flexibility and isolation.
For example, currently,
make test-integrationmust be executed in a physical server.It is because
docker xxxcannot be executed within a container (docker in docker is out of scope of this PR).Sometimes, it is useful for local debugging, as poetry cannot provide system level isolation, includes environment variables and shared libs.
This PR allows us to run
make test-integration-execwithin a container environment, after we have runmake test-integration-setupon this server.Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.