Add ADLFS property adls.account-host #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsdsantos
changed the title
Contributor
|
@vsdsantos can you run |
Contributor
|
Thanks for adding this @vsdsantos 🙌 |
Contributor
Author
No problem 😄 , thank you all for all the work on this tool! |
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
Closes apache#2015
# Rationale for this change
Enable the input of the ADLFS option `account_host` via the properties
option `adls.account-host`
# Are these changes tested?
Yes
# Are there any user-facing changes?
The option is now available :)
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
Closes apache#2015
# Rationale for this change
Enable the input of the ADLFS option `account_host` via the properties
option `adls.account-host`
# Are these changes tested?
Yes
# Are there any user-facing changes?
The option is now available :)
This was referenced Aug 14, 2025
Fokko
pushed a commit
that referenced
this pull request
Aug 18, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Related to #2326
We added support for `adls.account-host` in #2016 but this option is
only available in fsspec's `AzureBlobFileSystem` implementation for
version >=2024.7.0
See
fsspec/adlfs@126ffc0
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2015
Rationale for this change
Enable the input of the ADLFS option
account_hostvia the properties optionadls.account-hostAre these changes tested?
Yes
Are there any user-facing changes?
The option is now available :)