Skip to content

Bump Ruff to the latest version #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Jun 14, 2025
Merged

Bump Ruff to the latest version #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ repos:
- id: check-yaml
- id: check-ast
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.8.6
rev: v0.11.13
hooks:
- id: ruff
args: [ --fix, --exit-non-zero-on-fix ]
Expand Down
48 changes: 24 additions & 24 deletions tests/catalog/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,19 +323,19 @@ def test_properties_sets_headers(requests_mock: Mocker) -> None:
**{"header.Content-Type": "application/vnd.api+json", "header.Customized-Header": "some/value"},
)

assert (
catalog._session.headers.get("Content-type") == "application/json"
), "Expected 'Content-Type' default header not to be overwritten"
assert (
requests_mock.last_request.headers["Content-type"] == "application/json"
), "Config request did not include expected 'Content-Type' header"
assert catalog._session.headers.get("Content-type") == "application/json", (
"Expected 'Content-Type' default header not to be overwritten"
)
assert requests_mock.last_request.headers["Content-type"] == "application/json", (
"Config request did not include expected 'Content-Type' header"
)

assert (
catalog._session.headers.get("Customized-Header") == "some/value"
), "Expected 'Customized-Header' header to be 'some/value'"
assert (
requests_mock.last_request.headers["Customized-Header"] == "some/value"
), "Config request did not include expected 'Customized-Header' header"
assert catalog._session.headers.get("Customized-Header") == "some/value", (
"Expected 'Customized-Header' header to be 'some/value'"
)
assert requests_mock.last_request.headers["Customized-Header"] == "some/value", (
"Config request did not include expected 'Customized-Header' header"
)


def test_config_sets_headers(requests_mock: Mocker) -> None:
Expand All @@ -352,19 +352,19 @@ def test_config_sets_headers(requests_mock: Mocker) -> None:
catalog = RestCatalog("rest", uri=TEST_URI, warehouse="s3://some-bucket")
catalog.create_namespace(namespace)

assert (
catalog._session.headers.get("Content-type") == "application/json"
), "Expected 'Content-Type' default header not to be overwritten"
assert (
requests_mock.last_request.headers["Content-type"] == "application/json"
), "Create namespace request did not include expected 'Content-Type' header"
assert catalog._session.headers.get("Content-type") == "application/json", (
"Expected 'Content-Type' default header not to be overwritten"
)
assert requests_mock.last_request.headers["Content-type"] == "application/json", (
"Create namespace request did not include expected 'Content-Type' header"
)

assert (
catalog._session.headers.get("Customized-Header") == "some/value"
), "Expected 'Customized-Header' header to be 'some/value'"
assert (
requests_mock.last_request.headers["Customized-Header"] == "some/value"
), "Create namespace request did not include expected 'Customized-Header' header"
assert catalog._session.headers.get("Customized-Header") == "some/value", (
"Expected 'Customized-Header' header to be 'some/value'"
)
assert requests_mock.last_request.headers["Customized-Header"] == "some/value", (
"Create namespace request did not include expected 'Customized-Header' header"
)


@pytest.mark.filterwarnings(
Expand Down
Loading