-
Notifications
You must be signed in to change notification settings - Fork 414
add iceberg datafusion integration #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevinjqliu
merged 4 commits into
apache:main
from
kevinjqliu:kevinjqliu/datafusion-python
Jul 6, 2025
Merged
add iceberg datafusion integration #2075
kevinjqliu
merged 4 commits into
apache:main
from
kevinjqliu:kevinjqliu/datafusion-python
Jul 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Jun 8, 2025
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff 🙌 should we also add a section to the docs?
pyiceberg/table/__init__.py
Outdated
|
|
||
| return pl.scan_iceberg(self) | ||
|
|
||
| def __datafusion_table_provider__(self) -> Any: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| def __datafusion_table_provider__(self) -> Any: | |
| def __datafusion_table_provider__(self) -> IcebergDataFusionTable: |
4061236 to
6e1bce9
Compare
6e1bce9 to
fd7e87e
Compare
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
- Added pyiceberg table integration so that pyiceberg `Table` can be
pass in directly to datafusion's `register_table_provider`
- Added `datafusion` as a optional dependency
- Added docs for the integration:
<img width="1279" alt="Screenshot 2025-07-06 at 10 59 44 AM"
src="https://github.com/user-attachments/assets/f41f08e6-dd41-4012-ad96-2eaae805d28e"
/>
# Are these changes tested?
Yes
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
- Added pyiceberg table integration so that pyiceberg `Table` can be
pass in directly to datafusion's `register_table_provider`
- Added `datafusion` as a optional dependency
- Added docs for the integration:
<img width="1279" alt="Screenshot 2025-07-06 at 10 59 44 AM"
src="https://github.com/user-attachments/assets/f41f08e6-dd41-4012-ad96-2eaae805d28e"
/>
# Are these changes tested?
Yes
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tablecan be pass in directly to datafusion'sregister_table_providerdatafusionas a optional dependencyAre these changes tested?
Yes
Are there any user-facing changes?