Skip to content

maint: let requests handle params formatting #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 7 commits into from
Jun 14, 2025
Merged

maint: let requests handle params formatting #2086

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
083b458
feat: support optional params in rest catalog
jayceslesar Jun 12, 2025
2ce5e40
add test for the None case
jayceslesar Jun 12, 2025
c015840
handle `None` being passed in for a value
jayceslesar Jun 12, 2025
f66cd31
Update pyiceberg/catalog/rest/__init__.py
jayceslesar Jun 12, 2025
eee7c08
Update pyiceberg/catalog/rest/__init__.py
jayceslesar Jun 12, 2025
f1668f7
let requests handle the params
jayceslesar Jun 13, 2025
9861dfb
remove constant and import
jayceslesar Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import re
Copy link
Contributor

@Fokko Fokko Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import re

from enum import Enum
from typing import (
TYPE_CHECKING,
Expand Down Expand Up @@ -82,6 +83,9 @@
ICEBERG_REST_SPEC_VERSION = "0.14.1"


CAMEL_TO_SNAKE_CASE_PATTERN = re.compile(r"(?<!^)(?=[A-Z])")


Copy link
Contributor

@Fokko Fokko Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CAMEL_TO_SNAKE_CASE_PATTERN = re.compile(r"(?<!^)(?=[A-Z])")

class Endpoints:
get_config: str = "config"
list_namespaces: str = "namespaces"
Expand All @@ -95,7 +99,7 @@ class Endpoints:
register_table = "namespaces/{namespace}/register"
load_table: str = "namespaces/{namespace}/tables/{table}"
update_table: str = "namespaces/{namespace}/tables/{table}"
drop_table: str = "namespaces/{namespace}/tables/{table}?purgeRequested={purge}"
drop_table: str = "namespaces/{namespace}/tables/{table}"
table_exists: str = "namespaces/{namespace}/tables/{table}"
get_token: str = "oauth/tokens"
rename_table: str = "tables/rename"
Expand Down Expand Up @@ -617,7 +621,8 @@ def load_table(self, identifier: Union[str, Identifier]) -> Table:
@retry(**_RETRY_ARGS)
def drop_table(self, identifier: Union[str, Identifier], purge_requested: bool = False) -> None:
response = self._session.delete(
self.url(Endpoints.drop_table, prefixed=True, purge=purge_requested, **self._split_identifier_for_path(identifier)),
self.url(Endpoints.drop_table, prefixed=True, **self._split_identifier_for_path(identifier)),
params={"purgeRequested": purge_requested},
)
try:
response.raise_for_status()
Expand Down