-
Notifications
You must be signed in to change notification settings - Fork 414
[Avro] Accept dict with only 'type': 'null' as representation of null
#2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avro] Accept dict with only 'type': 'null' as representation of null
#2109
Conversation
kevinjqliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense, but i cant find a corresponding mention in the avro spec
cc @Fokko to chime in here
|
The spec seems to indicate that this is valid: Right under
List of primitive types
And then below the list:
Which is why |
|
ty that makes sense, thanks for the pointer |
|
Looks like theres a linter issue, could you run |
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the syntax looks a bit weird, I agree that this is valid:
I agree with @kevinjqliu that a test would be a very good idea, since we're moving this part to rust somewhere in the not-so-distant future :)
|
@Tishj I was not able to find or generate an avro manifest list file to verify this. Do you have one? |
|
@Tishj is this fix not needed anymore? |
This PR makes it so that a different serialization of the
nulltype is accepted, this variation is produced byavro-c(apache/avro'sclang implementation)Problem described in duckdb/duckdb-iceberg#305 (comment)