fix: correct type mismatch in avro zstd decompression. #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongyujiang
force-pushed
the
yuj/fix-zstd-decompress
branch
from
d09539c to
0b1d932
Compare
Fokko
approved these changes
Jun 20, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I'm able to reproduce it locally, great catch @zhongyujiang
def new_decoder(b: bytes) -> BinaryDecoder:
try:
from pyiceberg.avro.decoder_fast import CythonBinaryDecoder
> return CythonBinaryDecoder(b)
E TypeError: Argument 'input_contents' has incorrect type (expected bytes, got bytearray)
../../pyiceberg/avro/decoder.py:181: TypeError
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
The return type of the decompress method in `ZStandardCodec` should be
`bytes`, but it currently returns a `bytearray`, which causes an
exception when reading Avro files compressed with zstd.
```text
def new_decoder(b: bytes) -> BinaryDecoder:
try:
from pyiceberg.avro.decoder_fast import CythonBinaryDecoder
> return CythonBinaryDecoder(b)
E TypeError: Argument 'input_contents' has incorrect type (expected bytes, got bytearray)
```
# Are these changes tested?
Yes, `test_write_manifest`
# Are there any user-facing changes?
No.
<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
The return type of the decompress method in `ZStandardCodec` should be
`bytes`, but it currently returns a `bytearray`, which causes an
exception when reading Avro files compressed with zstd.
```text
def new_decoder(b: bytes) -> BinaryDecoder:
try:
from pyiceberg.avro.decoder_fast import CythonBinaryDecoder
> return CythonBinaryDecoder(b)
E TypeError: Argument 'input_contents' has incorrect type (expected bytes, got bytearray)
```
# Are these changes tested?
Yes, `test_write_manifest`
# Are there any user-facing changes?
No.
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The return type of the decompress method in
ZStandardCodecshould bebytes, but it currently returns abytearray, which causes an exception when reading Avro files compressed with zstd.Are these changes tested?
Yes,
test_write_manifestAre there any user-facing changes?
No.