perf: optimize table.add_files and inspect.files
#2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Jun 22, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the optimization
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Contributor
|
@jayceslesar looks like the linter isnt happy, could you run |
Contributor
Author
|
I wonder if we can eventually replace this portion with rust -- unsure what that implementation supports currently but would be fun to try it out https://github.com/apache/iceberg-rust/tree/main/crates/iceberg/src/inspect |
Contributor
|
yep thats the goal eventually. I also think the biggest perf bottleneck is reading the avro metadata files. Once we move that part to rust (apache/iceberg-rust#1328), Im curious to see how much the entire process improves. |
kevinjqliu
changed the title
table.add_files and inspect.filestable.add_files and inspect.files
Contributor
|
Thanks @jayceslesar btw i change the PR description so we dont close the 2 issues automatically |
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
Should help with apache#2130 and apache#2132 Modifies `Table.add_files` to explicitly use `inspect.data_files` and also parallelize `inspect._files` I didn't see anywhere else where looping over manifest entries was parallelized, so seems better to parallelize across manifests than within. No changes here but should be faster. --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Should help with apache#2130 and apache#2132 Modifies `Table.add_files` to explicitly use `inspect.data_files` and also parallelize `inspect._files` I didn't see anywhere else where looping over manifest entries was parallelized, so seems better to parallelize across manifests than within. No changes here but should be faster. --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #2130 and #2132
Modifies
Table.add_filesto explicitly useinspect.data_filesand also parallelizeinspect._filesI didn't see anywhere else where looping over manifest entries was parallelized, so seems better to parallelize across manifests than within.
No changes here but should be faster.