Skip to content

Relax REST client /v1/config response constraints #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 5 commits into from
Jun 26, 2025
Merged

Relax REST client /v1/config response constraints #2148

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c6c89a
Google BigLake Metastore Catalog issue
ccancellieri Jun 24, 2025
64e4ffa
Update pyiceberg/catalog/rest/__init__.py
kevinjqliu Jun 25, 2025
0b29646
Update pyiceberg/catalog/rest/__init__.py
kevinjqliu Jun 25, 2025
735938b
Update pyiceberg/catalog/rest/__init__.py
kevinjqliu Jun 25, 2025
ba5437d
Update pyiceberg/catalog/rest/__init__.py
kevinjqliu Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel):


class ConfigResponse(IcebergBaseModel):
defaults: Properties = Field()
overrides: Properties = Field()
defaults: Optional[Properties] = Field(default_factory=dict)
overrides: Optional[Properties] = Field(default_factory=dict)


class ListNamespaceResponse(IcebergBaseModel):
namespaces: List[Identifier] = Field()
namespaces: Optional[List[Identifier]] = Field(default_factory=list)
Copy link
Contributor

@kevinjqliu kevinjqliu Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ones odd, i think we should revert this change. The listNamespace response should return an empty namespaces list

https://github.com/apache/iceberg/blob/b7154119f97870608429d5a9950aaaad6d2a0276/open-api/rest-catalog-open-api.yaml#L3967-L3976



class NamespaceResponse(IcebergBaseModel):
Expand Down
Loading