-
Notifications
You must be signed in to change notification settings - Fork 414
update daft links #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update daft links #2169
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @ccmao1130, we can move this forward as soon as the CI is green 👍
| psycopg2-binary = { version = ">=2.9.6", optional = true } | ||
| sqlalchemy = { version = "^2.0.18", optional = true } | ||
| getdaft = { version = ">=0.2.12", optional = true } | ||
| daft = { version = ">=0.5.0", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the minor version requires running poetry lock. What's the rationale for bumping to 0.5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed our package from getdaft to daft and the earliest version for daft starts at v0.4.7 but we wanted to bump to v0.5.0
|
@ccmao1130 could you run |
|
@kevinjqliu Okay I think it should be okay now? (sorry not a developer hahaha....) |
|
Looks like something changed in the newer version This test failed iceberg-python/tests/integration/test_reads.py Lines 333 to 345 in e33cf5a
|
kevinjqliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green now. LGTM!
|
Thanks Kevin! |
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
We recently changed our site domain so want to update all Daft
documentation links. And noticed that our package should be updated from
`getdaft` to `daft`
# Are these changes tested?
yes
# Are there any user-facing changes?
no
<!-- In the case of user-facing changes, please add the changelog label.
-->
Rationale for this change
We recently changed our site domain so want to update all Daft documentation links. And noticed that our package should be updated from
getdafttodaftAre these changes tested?
yes
Are there any user-facing changes?
no