Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

Rationale for this change

ugi is a Hive Catalog property. It was accidentally added to the REST catalog section in 5209874#diff-497e037708cc64870c6ba9372f6064a69ca1e74d65d6195dcee5a44851e8b47dR151

#2175 removed it from the REST catalog section.

This PR adds ugi back to the Hive Catalog section

Screenshot 2025-07-08 at 7 48 41 AM

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu kevinjqliu requested a review from Fokko July 8, 2025 14:50
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @kevinjqliu

@Fokko Fokko merged commit 2b9f9e2 into apache:main Jul 8, 2025
3 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/add-back-ugio branch July 8, 2025 20:41
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
[`ugi` is a Hive Catalog
property](https://github.com/apache/iceberg-python/blob/e33cf5ac1adf47131d4992bdb686f0e58f4e4669/pyiceberg/catalog/hive.py#L322-L327).
It was accidentally added to the REST catalog section in
apache@5209874#diff-497e037708cc64870c6ba9372f6064a69ca1e74d65d6195dcee5a44851e8b47dR151

apache#2175 removed it from the REST catalog section. 

This PR adds `ugi` back to the Hive Catalog section

<img width="666" alt="Screenshot 2025-07-08 at 7 48 41 AM"
src="https://github.com/user-attachments/assets/42247bae-4dfd-4688-b4d5-a33bd94d686b"
/>

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants