Add RemovePartitionSpecsUpdate event #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
force-pushed
the
remove_partition_specs
branch
from
ab1e3b8 to
9df1bd0
Compare
Contributor
|
@rambleraptor could you rebase and resolve the conflicts here? |
rambleraptor
force-pushed
the
remove_partition_specs
branch
from
9df1bd0 to
cb9891d
Compare
Contributor
Author
|
@kevinjqliu rebased! |
kevinjqliu
approved these changes
Sep 23, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM, need an extra s in the name
rambleraptor
force-pushed
the
remove_partition_specs
branch
from
00fb675 to
e8830bf
Compare
Contributor
Author
|
@kevinjqliu rebased + changes applied! |
Contributor
|
Thanks for the PR @rambleraptor and thanks @geruh for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This adds RemovePartitionSpecsUpdate, another missing TableMetadata update event.
It also ends up testing AddPartitionSpecUpdate, which it looks like it untested.
REST API Spec Reference
Are these changes tested?
Unit tests added.
Are there any user-facing changes?