Support reading ns from pyarrow #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 7, 2025
Fokko
reviewed
Aug 7, 2025
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
reviewed
Aug 7, 2025
Fokko
approved these changes
Aug 7, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
One nit, apart from that, this looks great! Thanks @rambleraptor for working on this 👍
Contributor
Author
|
@Fokko responded. thanks a lot! |
kevinjqliu
reviewed
Aug 8, 2025
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def arrow_table_schema_with_nanoseconds_timestamp_precisions() -> "pa.Schema": |
Contributor
Author
There was a problem hiding this comment.
removed this in the follow-up PR.
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
Closes apache#2270
Related to apache#1045
# Rationale for this change
This allows us to read nanosecond information from pyarrow. Right now,
we always downcast to microseconds or throw an error. By passing through
the format-version, we can grab nanosecond precision *just for v3
tables*
# Are these changes tested?
Included a test. I can't do a test involving writing since we don't
support v3 writing yet (there's a PR out for that)
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: Fokko Driesprong <fokko@apache.org>
This was referenced Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2270
Related to #1045
Rationale for this change
This allows us to read nanosecond information from pyarrow. Right now, we always downcast to microseconds or throw an error. By passing through the format-version, we can grab nanosecond precision just for v3 tables
Are these changes tested?
Included a test. I can't do a test involving writing since we don't support v3 writing yet (there's a PR out for that)
Are there any user-facing changes?