Skip to content

Conversation

@ayushjariyal
Copy link
Contributor

issue #2341

Initially, I updated markdownlint-cli from v0.43.0 → v0.45.0, but running make lint failed with errors:

Screenshot from 2025-08-21 09-58-10

After that, I downgraded slightly to v0.44.0 (instead of v0.45.0), and make lint executed successfully:

Screenshot from 2025-08-21 10-01-28

@ayushjariyal
Copy link
Contributor Author

@Fokko, could you please review this PR and let me know why updating to v0.45.0 caused make lint to fail

@Fokko
Copy link
Contributor

Fokko commented Aug 21, 2025

@ayushjariyal This is caused by that 0.45.0 introduces a new check that check if there is only one heading in Markdown. To get the check passing we need to look into the Markdown files and resolve the issues.

@ayushjariyal
Copy link
Contributor Author

@Fokko, I’ve updated markdownlint-cli from v0.44.0 to v0.45.0 and adjusted the Markdown files accordingly. After testing with make lint, everything passes successfully

Screenshot from 2025-08-21 19-50-47

Please let me know if there are any further improvements you’d recommend.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ayushjariyal Thanks again!

@Fokko Fokko merged commit 5d6e1e2 into apache:main Aug 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants