Skip to content

Fix rest test with ssl_ca_bundle due to conflicts with OS environment #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 3 commits into from
Aug 28, 2025
Merged

Fix rest test with ssl_ca_bundle due to conflicts with OS environment #2394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
757f298
Fix rest test with ssl_ca_bundle due to conflicts with OS environment
manuzhang Aug 28, 2025
6329d85
Use monkeypatch.delenv
manuzhang Aug 28, 2025
9964996
Patch
Fokko Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/catalog/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ def test_update_namespace_properties_invalid_namespace(rest_mock: Mocker) -> Non
assert "Empty namespace identifier" in str(e.value)


def test_request_session_with_ssl_ca_bundle() -> None:
def test_request_session_with_ssl_ca_bundle(monkeypatch: pytest.MonkeyPatch) -> None:
# Given
catalog_properties = {
"uri": TEST_URI,
Expand All @@ -1496,6 +1496,8 @@ def test_request_session_with_ssl_ca_bundle() -> None:
},
}
with pytest.raises(OSError) as e:
monkeypatch.delenv("REQUESTS_CA_BUNDLE", raising=False)
monkeypatch.delenv("CURL_CA_BUNDLE", raising=False)
# Missing namespace
RestCatalog("rest", **catalog_properties) # type: ignore
assert "Could not find a suitable TLS CA certificate bundle, invalid path: path_to_ca_bundle" in str(e.value)
Expand Down