Skip to content

Set the ManifestEntryStatus #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 5 commits into from
Sep 2, 2025
Merged

Set the ManifestEntryStatus #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d1a68d
Set the ManifestEntryStatus
Fokko Sep 1, 2025
5214de5
Cleanup
Fokko Sep 1, 2025
37b53aa
Extend test
Fokko Sep 1, 2025
d171ec4
Cleanup
Fokko Sep 1, 2025
aa0ef95
Update manifest.py
Fokko Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions pyiceberg/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,18 +1087,15 @@ def add_entry(self, entry: ManifestEntry) -> ManifestWriter:
return self

def add(self, entry: ManifestEntry) -> ManifestWriter:
if entry.sequence_number is not None and entry.sequence_number >= 0:
self.add_entry(
ManifestEntry.from_args(
snapshot_id=self._snapshot_id, sequence_number=entry.sequence_number, data_file=entry.data_file
)
)
else:
self.add_entry(
ManifestEntry.from_args(
status=ManifestEntryStatus.ADDED, snapshot_id=self._snapshot_id, data_file=entry.data_file
)
self.add_entry(
ManifestEntry.from_args(
status=ManifestEntryStatus.ADDED,
snapshot_id=self._snapshot_id,
sequence_number=entry.sequence_number if entry.sequence_number != UNASSIGNED_SEQ else None,
data_file=entry.data_file,
)
)

return self

def delete(self, entry: ManifestEntry) -> ManifestWriter:
Expand Down
4 changes: 4 additions & 0 deletions tests/catalog/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,10 @@ def test_merge_manifests_local_file_system(catalog: SqlCatalog, arrow_table_with
tbl.append(arrow_table_with_null)

assert len(tbl.scan().to_arrow()) == 5 * len(arrow_table_with_null)
current_snapshot = tbl.current_snapshot()
assert current_snapshot
manifests = current_snapshot.manifests(tbl.io)
assert len(manifests) == 1


@pytest.mark.parametrize(
Expand Down